Skip to content

fix(llmobs): fix llmobs to apm link for spans #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(llmobs): fix llmobs to apm link for spans #4104

wants to merge 4 commits into from

Conversation

@rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Nov 6, 2025 •
edited
Loading

What does this PR do?

We were not attaching the apm span trace id (+ other info) to the llmobs span events, so the View in APM button in the LLMObs trace/span view was not showing up.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@rarguelloF rarguelloF marked this pull request as ready for review November 6, 2025 14:21
@rarguelloF rarguelloF requested a review from a team as a code owner November 6, 2025 14:21
@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-11-07 09:50:19

Comparing candidate commit 7d34a8d in PR branch rarguelloF/fix-llmobs-apm-link with baseline commit 0cbdb0c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@rarguelloF
Copy link
Contributor Author

rarguelloF commented Nov 7, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 7, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-11-07 13:09:39 UTC ℹ️ Start processing command /merge

2025-11-07 13:09:48 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-11-07 17:10:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jboolean jboolean jboolean approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rarguelloF @jboolean